Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: animation-dci supports custom icon #247

Merged
merged 2 commits into from
Jul 26, 2024
Merged

chore: animation-dci supports custom icon #247

merged 2 commits into from
Jul 26, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Jul 18, 2024 •
edited
Loading

  • animation-dci supports custom icon
    open or drop a dci icon on label to display dci icon

@kegechen kegechen requested a review from zccrs July 18, 2024 06:57
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 18, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkgui
838d567 
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#247
@deepin-ci-robot deepin-ci-robot mentioned this pull request Jul 18, 2024
Merged
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 18, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@kegechen kegechen mentioned this pull request Jul 18, 2024
Merged
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 18, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkgui
7fa46dc 
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#247
zccrs
zccrs requested changes Jul 19, 2024
View reviewed changes
examples/animation-dci/main.cpp Outdated Show resolved Hide resolved
examples/animation-dci/main.cpp Outdated Show resolved Hide resolved
zccrs
zccrs requested changes Jul 19, 2024
View reviewed changes
src/util/ddciicon.cpp Outdated Show resolved Hide resolved
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 19, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkgui
e700004 
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#247
@kegechen kegechen changed the title DDciIconImage support static image chore: animation-dci supports custom icon Jul 19, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 19, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkgui
32f4fa5 
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#247
@kegechen kegechen requested a review from zccrs July 19, 2024 03:32
zccrs
zccrs previously approved these changes Jul 19, 2024
View reviewed changes
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 22, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkgui
e01eb25 
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#247
@kegechen kegechen requested a review from zccrs July 22, 2024 10:48
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
chore: animation-dci supports custom icon
b84a7f6 
for test dci animation icon
@kegechen
fix: wrong judgment conditions
c8e8fd6 
assert player not nullptr
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 26, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkgui
5caa869 
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#247
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在IconWidget类中，open按钮的信号连接使用了Lambda表达式，但没有检查Lambda表达式是否有效。
  • setAcceptDrops方法被调用，但没有检查返回值，可能会导致未处理的初始化错误。
  • QFileDialog::getOpenFileName的返回值应该检查是否为空，以避免潜在的空指针异常。
  • QDropEvent的类型检查应该在else if语句中进行，而不是在单独的if语句中。
  • QString::split方法使用了"\r\n"作为分隔符，但在某些情况下，可能需要考虑使用更通用的分隔符，例如QRegExp("\\s+")。
  • QUrl::path方法返回的是一个QString，但没有检查url.path()是否为空。
  • DDciIcon构造函数的错误处理不明确，如果url.path()不能解析为有效的图标文件，构造函数会返回一个无效的图标。
  • player.setIcon(icon);和player.setMode(DDciIcon::Normal);应该在if (!icon.isNull())条件内执行，以避免在图标无效时设置图标。

是否建议立即修改:
是

@kegechen kegechen merged commit 1ffd986 into linuxdeepin:master Jul 26, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zccrs zccrs zccrs approved these changes

@18202781743 18202781743 Awaiting requested review from 18202781743

@FeiWang1119 FeiWang1119 Awaiting requested review from FeiWang1119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kegechen @deepin-ci-robot @zccrs